[products] Show Identifiers in product pages #5356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captn3m0
force-pushed
the
show-product-identifiers
branch
from
0cf74e7
to
5828d83
Compare
|
Working on generating links, converting to draft. |
marcwrobel
added a commit
that referenced
this pull request
Jul 6, 2024
Based on modifications done in #5356.
marcwrobel
added a commit
that referenced
this pull request
Jul 6, 2024
Looks like it was wrong, see #5356.
marcwrobel
added a commit
that referenced
this pull request
Jul 6, 2024
Looks like it was wrong, see #5356.
marcwrobel
added a commit
that referenced
this pull request
Jul 6, 2024
Looks like it was wrong, see #5356.
marcwrobel
reviewed
Jul 6, 2024
marcwrobel
added a commit
that referenced
this pull request
Jul 6, 2024
Based on modifications done in #5356.
marcwrobel
added a commit
that referenced
this pull request
Jul 6, 2024
Looks like it was wrong, see #5356.
marcwrobel
added a commit
that referenced
this pull request
Jul 6, 2024
Looks like it was wrong, see #5356.
marcwrobel
added a commit
that referenced
this pull request
Jul 6, 2024
Looks like it was wrong, see #5356.
This was referenced Jul 6, 2024
Merged
|
I'll drop the PURL fix commits and rebase this. A PURL validator will be nice to have. |
@captn3m0, don't mind I am doing it right now. |
marcwrobel
force-pushed
the
show-product-identifiers
branch
from
eb06703
to
4d0b3ba
Compare
Simple version to start with. We can look at a PURL->URL generator later
marcwrobel
force-pushed
the
show-product-identifiers
branch
from
4d0b3ba
to
64d66eb
Compare
marcwrobel
reviewed
Jul 6, 2024
There was a problem hiding this comment.
Overall LGTM.
Before merging I will:
- add a validator to validate all identifiers
- see if I should exclude the validation of those generated URLs from product-data-validator
- see if I can improve the rendering (having a " Show Product Identifiers" at the bottom seems a bit strange).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we don't expose identifiers beyond storing them in the front-matter. This will start exposing the identifiers on the website as a start.
Simple version to start with, based on https://github.com/package-url/packageurl-python/blob/main/src/packageurl/contrib/purl2url.py, with a few more types, and no support for "versions", since identifiers won't have that.