Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new product] contour #5308

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

mritunjaysharma394
Copy link
Contributor

@mritunjaysharma394 mritunjaysharma394 commented Jun 17, 2024

This PR adds contour to endoflife.date project, let me know if it needs more improvements, I have tried to cover most details from upstream, thanks for maintaining it!

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than suggested changes:

Adding two unsupported releases will be helpful to users (1.25 and 1.24), with the eol dates adjusted for them accordingly.

Q: As per my understanding, new features only happen in a .0 release, so no release cycle sees active development. So a x.y.1 patch release will never get new features. If that's the case, we don't need to add Active Support column, but I'd like to confirm this.

Rest looks good to me, thanks for your contribution

products/contour.md Outdated Show resolved Hide resolved
products/contour.md Outdated Show resolved Hide resolved
products/contour.md Outdated Show resolved Hide resolved
products/contour.md Outdated Show resolved Hide resolved
products/contour.md Outdated Show resolved Hide resolved
products/contour.md Outdated Show resolved Hide resolved
products/contour.md Show resolved Hide resolved
products/contour.md Outdated Show resolved Hide resolved
products/contour.md Outdated Show resolved Hide resolved
products/contour.md Show resolved Hide resolved
Signed-off-by: Mritunjay <[email protected]>
@mritunjaysharma394
Copy link
Contributor Author

Thanks so much for the detailed review and your time @captn3m0!
I think I have resolved most of your suggestions and regarding your questions, I am new to this project so I am a bit confused about the Active Support column, are you referring to eolColumn: Bug and Security Fixes? If yes, I think the project mentions that its patch release deal with only that and that's why I kept it, let me know if you think we should remove it, I will change it

for ref:
https://github.com/projectcontour/contour/blob/main/RELEASES.md#patch-releases
https://projectcontour.io/resources/support/

Thanks again for doing it!

@captn3m0
Copy link
Member

I was asking about eoasColumn, which tracks Active Support (See https://endoflife.date/drupal for example) to track if new features are included in support. Reading the links, doesn't looks like that is the case, so we can ignore it.

I'll do a final review and merge soon, thanks for your contribution.

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution 🥇

@captn3m0 captn3m0 merged commit af5f9f0 into endoflife-date:master Jun 18, 2024
5 checks passed
Copy link

welcome bot commented Jun 18, 2024

Thank you and congratulations for your first contribution! endoflife.date is a community wiki, and we're always looking for more contributions 🥇 💯 🎉.

@mritunjaysharma394
Copy link
Contributor Author

Thanks a lot for explaining me and helping me out in the process, really amazing of you to maintain such a great project!

@mritunjaysharma394 mritunjaysharma394 deleted the patch-2 branch June 18, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants