[envoy] Adds more identifiers #5297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captn3m0
added
the
product-fixes
marcwrobel
approved these changes
Jun 16, 2024
|
LGTM, but what is the rationale behind those addition ? For example how do we know which docker image to add ? Because this PR adds https://hub.docker.com/r/envoyproxy/envoy-alpine with a last update in 2022. |
marcwrobel
added
product-updates
Initial reason was to start adding Chainguard image references. They have a lot of overlap with our product list so thought it made sense. My deciding factors were:
In general, is there a good chance that a production system will be running using this image, so our data can be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.