Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu] Add missing Ubuntu releases #5268

Merged

Conversation

joshmcorreia
Copy link
Contributor

Add missing Ubuntu releases and make the use of the lts property consistent across all releases.

Copy link

welcome bot commented Jun 12, 2024

Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals.

@usta
Copy link
Member

usta commented Jun 13, 2024

-1 👎 from me for this PR because lts is already defined as false if that tag is not used
Also other part is getting my 👎 too because :
historical verions of ANY product wont related to our product's goal.
endoflife.date is not for keeping version infomations ( wikidata is for that ) and endoflife.date 's purpose is to let people see if any of their product's eol is reached or nearly reached. Adding a 10+ years old product wont help anyone

Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope to setting anything like lts: false because it is already defined as false if not mentioned
historical verions of ANY product wont related to our product's goal.
endoflife.date is not for keeping version infomations ( wikidata is for that ) and endoflife.date 's purpose is to let people see if any of their product's eol is reached or nearly reached. Adding a 10+ years old product wont help anyone

@usta
Copy link
Member

usta commented Jun 13, 2024

So i'm so sorry that i'm closing this pr

@usta usta closed this Jun 13, 2024
@captn3m0
Copy link
Member

We're already tracking 19 year old releases, I don't see why we can't add a few more. Plus, really old releases are automatically hidden anyway - this just makes it a better data source.

Agree on the lts changes - those can be dropped, but the rest can be merged?

@BiNZGi BiNZGi reopened this Jun 13, 2024
Copy link
Member

@BiNZGi BiNZGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reopened, please remove the lts: false entries, they are default and only making the md file longer to read.

@joshmcorreia joshmcorreia force-pushed the feature/add_missing_ubuntu_releases branch 2 times, most recently from 604b28a to 3487380 Compare June 13, 2024 18:42
@joshmcorreia joshmcorreia force-pushed the feature/add_missing_ubuntu_releases branch from 3487380 to 0f8fd8d Compare June 13, 2024 18:44
@joshmcorreia
Copy link
Contributor Author

PR reopened, please remove the lts: false entries, they are default and only making the md file longer to read.

Fixed. I was following the same pattern as the other old releases but since you don't want lts: false I went ahead and made a separate commit that removes them from the older releases. Thanks!

@joshmcorreia joshmcorreia changed the title Add missing Ubuntu releases [Ubuntu] Add missing Ubuntu releases Jun 13, 2024
@joshmcorreia joshmcorreia requested a review from BiNZGi June 13, 2024 19:09
@usta
Copy link
Member

usta commented Jun 13, 2024

Fixed. I was following the same pattern as the other old releases

Could you pinpoint the products which have lts: false so we can also fix them too ,

Btw Thank you i hope you didnt get me wrong or i didnt make you feel sad/bad

@joshmcorreia
Copy link
Contributor Author

No worries, also I fixed the ones that had lts:false (they were older Ubuntu entries).

Copy link
Member

@usta usta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiNZGi BiNZGi merged commit dc78519 into endoflife-date:master Jun 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants