-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ubuntu] Add missing Ubuntu releases #5268
[Ubuntu] Add missing Ubuntu releases #5268
Conversation
Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals. |
-1 👎 from me for this PR because lts is already defined as false if that tag is not used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope to setting anything like lts: false because it is already defined as false if not mentioned
historical verions of ANY product wont related to our product's goal.
endoflife.date is not for keeping version infomations ( wikidata is for that ) and endoflife.date 's purpose is to let people see if any of their product's eol is reached or nearly reached. Adding a 10+ years old product wont help anyone
So i'm so sorry that i'm closing this pr |
We're already tracking 19 year old releases, I don't see why we can't add a few more. Plus, really old releases are automatically hidden anyway - this just makes it a better data source. Agree on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR reopened, please remove the lts: false
entries, they are default and only making the md file longer to read.
604b28a
to
3487380
Compare
3487380
to
0f8fd8d
Compare
Fixed. I was following the same pattern as the other old releases but since you don't want |
Could you pinpoint the products which have lts: false so we can also fix them too , Btw Thank you i hope you didnt get me wrong or i didnt make you feel sad/bad |
No worries, also I fixed the ones that had lts:false (they were older Ubuntu entries). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add missing Ubuntu releases and make the use of the
lts
property consistent across all releases.