Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation about testing local changes #2102

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Improve documentation about testing local changes #2102

merged 2 commits into from
Dec 20, 2022

Conversation

williamdes
Copy link
Contributor

No description provided.

@captn3m0
Copy link
Member

Can you drop the favicon commit from here? Would like to tackle that separately, since we aren't sure about the current icon (#978).

@williamdes
Copy link
Contributor Author

Can you drop the favicon commit from here? Would like to tackle that separately, since we aren't sure about the current icon (#978).

Yes, done

captn3m0
captn3m0 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure why --interactive isn't needed for the docker invocation. Ctrl+C works for me though, so LGTM

@captn3m0 captn3m0 merged commit 1bd24ab into endoflife-date:master Dec 20, 2022
@williamdes
Copy link
Contributor Author

I'm unsure why --interactive isn't needed for the docker invocation. Ctrl+C works for me though, so LGTM

It's on the jekyll docs and I always did see interactive for such CLIs ^^

@williamdes williamdes deleted the docs-improve branch December 20, 2022 07:06
@williamdes williamdes changed the title Improve documentation + fix favicon Improve documentation about testing local changes Dec 20, 2022
@williamdes
Copy link
Contributor Author

I'm unsure why --interactive isn't needed for the docker invocation. Ctrl+C works for me though, so LGTM

Oh I understood the opposite, I can add it. It can probably help
But it's not on jekyll docs

@captn3m0
Copy link
Member

Will track this down later, it worked for me with the latest docker so 👍🏽.

Thanks for the PR 💯

@marcwrobel marcwrobel added the enhancement New feature or request label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captn3m0 captn3m0 captn3m0 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@williamdes @captn3m0 @marcwrobel