Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Product] Mageia #2049

Merged
merged 3 commits into from
Dec 16, 2022
Merged

[New Product] Mageia #2049

merged 3 commits into from
Dec 16, 2022

Conversation

@usta usta changed the title [mageia]: new product [New Product] Mageia Dec 14, 2022
@usta usta added the new-product This PR adds a new product to the website. label Dec 14, 2022
@usta
Copy link
Member

usta commented Dec 14, 2022

@moviuro you need to add latest tags if you want to show links to related product if you dont want links please add
releaseColumn: false line so this column wont shown :
image

Also could you remove /en/ part from link to make is accessable for other languages

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please drop the Contao commits from this PR.
  • Please add some text about the support policy, or whatever has been the norm so far.

products/mageia.md Outdated Show resolved Hide resolved
products/mageia.md Outdated Show resolved Hide resolved
products/mageia.md Show resolved Hide resolved
@moviuro
Copy link
Contributor Author

moviuro commented Dec 15, 2022

@captn3m0 The contao issue is because I forked from endoflife-date/master. Which branch should I fork from next time?

@captn3m0
Copy link
Member

The additional commits were because I force-pushed to #master to squash the contao commits. Sorry about that, I've dropped the commits from this PR as well.

@captn3m0
Copy link
Member

Capitalized the title and changed the eolColumn to Supported. Otherwise, End-of-Life shows up as Yes, in green, which is confusing:

image

Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@captn3m0
Copy link
Member

I'm skeptical of using mageia in the releaseLabel (it repeats in every row). Filed #2068 separately to track that however.

Going ahead and merging this.

@captn3m0 captn3m0 merged commit ddbbabb into endoflife-date:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants