Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop nox in favor of vanilla scripts #566

Merged
merged 9 commits into from
Nov 30, 2019
Merged

Drop nox in favor of vanilla scripts #566

merged 9 commits into from
Nov 30, 2019

Conversation

florimondmanca
Copy link
Member

Fixes #239. Also based on some discussion @tomchristie and I had offline.

@florimondmanca
Copy link
Member Author

Hmm… pytest is showing a "Could not load plugin" error:

pluggy.manager.PluginValidationError: Plugin 'trio' could not be loaded: (attrs 18.2.0 (/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages), Requirement.parse('attrs>=19.2.0'), {'trio'})!

This happened to me in asgi-lifespan earlier today. Probably due to a silly dependency resolution issue… 😕 Not sure why it's only happening now; there hasn't been a release in trio, attrs, pytest or pluggy recently that seems to change the behavior.

Anyway, forcing attrs>=19.2 should fix it on our end, but it's definitely a hack…

@florimondmanca
Copy link
Member Author

florimondmanca commented Nov 29, 2019

It seems the Windows build is stalling, and has been since the addition of Unix socket support (#511 - see build here).

We didn't notice because the job was running last, and was allowed to fail, so the build was green even though the Windows job hadn't finished yet (and would finish minutes later).

My most obvious guess would be that Unix domain sockets… aren't available on Windows, but for some reason open_uds_stream() is stalling instead of failing.

I pushed a commit here to revert to the old situation, but we'd need to skip tests that use Unix sockets on Windows.

@florimondmanca florimondmanca added the tooling Changes to our CI/CD, tests setup, etc. label Nov 29, 2019
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
One minor question about how we ought to handle serving the docs vs building the docs.

docs/contributing.md Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@florimondmanca
Copy link
Member Author

@tomchristie Are we good running with scripts/docs-{build,serve}?

@tomchristie
Copy link
Member

@florimondmanca - Personally I'd probably prefer scripts/docs build and scripts/docs serve, but either way let's pull this in for now and we can figure out if there's anything else we want to iterate on later. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Changes to our CI/CD, tests setup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scripts as a single top-level point of project automation.
2 participants