Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer versions of httpcore #2885

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Conversation

paulschreiber
Copy link
Contributor

Summary

Support newer versions of httpcore. httpcore 1.0.0 was release October 6, 2023.

Fixes #2884.

httpcore 1.0.0 was release October 6, 2023.
@tomchristie
Copy link
Member

Thanks. 🙂

So... from httpcore 1.0 onwards, the async dependencies are optional.
The minimal version of this probably needs to use httpcore[asyncio,trio] as a dependency.

Although actually we want to push through and have httpx[asyncio] and httpx[trio] become optionals...

See #2858

Co-authored-by: Kar Petrosyan <[email protected]>
@tomchristie
Copy link
Member

Referring back to my previous review :)

This pull request should require both 'httpcore' and 'anyio'. (Effectively the same as requiring 'httpcore[asyncio]')
We could choose to roll a release from that point if we wanted too. 0.25.1 should be fine - we don't have any API breaking changes here, just a dependency upgrade.

Actually what we really want is PR #2858, which addresses this more comprehensively with the async dependencies no longer included by default. Tho we can treat that as a follow-up aimed at the upcoming 1.0 release.

See #947 (comment)

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion here would be...

  • Either add anyio to the dependencies list, or use httpcore[asyncio].
  • Add "update httpcore dependency" to the CHANGELOG.

And then we follow up with a new minor point release.

@tomchristie
Copy link
Member

I'm happy to roll a minor point release with this if the above suggestions are resolved.
Alternatively we can pass on this and merge #2858 with a new major release planned.

(We'll do that either way, but we can have an interim release if we want.)

@tomchristie
Copy link
Member

Okay I think if we update the CHANGELOG.md as part of this pull request, then we should merge this and roll an 0.25.1 release.

@tomchristie tomchristie merged commit 280a89a into encode:master Nov 2, 2023
5 checks passed
@@ -29,7 +29,8 @@ classifiers = [
]
dependencies = [
"certifi",
"httpcore>=0.18.0,<0.19.0",
"httpcore",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to pin version for httpcore and anyio here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want pinning here then...

  • We should probably pin anyio to the >=4.0.0,<5.0.0 range.
  • We can pin httpcore to the >=1.0.0,<2.0.0 range. (Actually I think we can go lower than that, but...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support httpcore >= 1.0.0
4 participants