Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links 404/302/303 in docs/community #6387

Merged
merged 5 commits into from
Jan 8, 2019

Conversation

adrienbrunet
Copy link
Contributor

Following Issue #6289 recommendations, I installed textlint with the rule textlint-rule-no-dead-link.

Here is the relevant output that I fixed with this PR. At the end, you can find the broken URLs found that I did not fix. I'm not sure what to do with those.

FIXED

## docs/community/3.1-announcement.md
33:379  error    https://cramer.io/2011/03/08/building-cursors-for-the-disqus-api is dead. (404 Not Found)
117:83   error    https://www.transifex.com/projects/p/django-rest-framework/ is dead. (301 MOVED PERMANENTLY) no-dead-link
158:153  ✓ error  https://github.com/evonove/django-oauth-toolkit is redirected to https://github.com/jazzband/django-oauth-toolkit. (301 Moved Permanently) no-dead-link
163:35   ✓ error  https://jpadilla.github.io/django-rest-framework-xml is redirected to https://jpadilla.github.io/django-rest-framework-xml/. (301 Moved Permanently) no-dead-link
164:37   ✓ error  https://jpadilla.github.io/django-rest-framework-yaml is redirected to https://jpadilla.github.io/django-rest-framework-yaml/. (301 Moved Permanently)  no-dead-link
165:39   ✓ error  https://jpadilla.github.io/django-rest-framework-jsonp is redirected to https://jpadilla.github.io/django-rest-framework-jsonp/. (301 Moved Permanently) no-dead-link

## docs/community/3.4-announcement.md
45:105  ✓ error  https://jobs.rover.com/ is redirected to https://www.rover.com/careers/. (301 Moved Permanently)  no-dead-link
45:139  ✓ error  https://getsentry.com/welcome/ is redirected to https://getsentry.com/auth/login/. (302 FOUND)   no-dead-link

## docs/community/3.5-announcement.md
42:97   ✓ error  https://jobs.rover.com/ is redirected to https://www.rover.com/careers/. (301 Moved Permanently)  no-dead-link
42:131  ✓ error  https://getsentry.com/welcome/ is redirected to https://getsentry.com/auth/login/. (302 FOUND)   no-dead-link

## docs/community/3.6-announcement.md
51:97   ✓ error  https://jobs.rover.com/ is redirected to https://www.rover.com/careers/. (301 Moved Permanently)  no-dead-link
51:131  ✓ error  https://getsentry.com/welcome/ is redirected to https://getsentry.com/auth/login/. (302 FOUND) no-dead-link

## docs/community/3.7-announcement.md
44:101  ✓ error  https://jobs.rover.com/ is redirected to https://www.rover.com/careers/. (301 Moved Permanently) no-dead-link
44:135  ✓ error  https://getsentry.com/welcome/ is redirected to https://getsentry.com/auth/login/. (302 FOUND) no-dead-link

## docs/community/3.8-announcement.md
33:69   ✓ error  https://jobs.rover.com/ is redirected to https://www.rover.com/careers/. (301 Moved Permanently) no-dead-link
33:103  ✓ error  https://getsentry.com/welcome/ is redirected to https://getsentry.com/auth/login/. (302 FOUND) no-dead-link

## docs/community/3.9-announcement.md
44:107  ✓ error  https://jobs.rover.com/ is redirected to https://www.rover.com/careers/. (301 Moved Permanently) no-dead-link
44:141  ✓ error  https://getsentry.com/welcome/ is redirected to https://getsentry.com/auth/login/. (302 FOUND) no-dead-link

## docs/community/funding.md
126:13   error    https://www.django-rest-framework.org/topics/3.4-announcement/ is dead. (404 Not Found) no-dead-link
126:87   error    https://www.django-rest-framework.org/topics/3.5-announcement/ is dead. (404 Not Found) no-dead-link
127:13   error    https://www.django-rest-framework.org/topics/3.6-announcement/ is dead. (404 Not Found) no-dead-link
128:21   error    https://www.django-rest-framework.org/topics/3.7-announcement/ is dead. (404 Not Found) no-dead-link
129:28   error    https://www.django-rest-framework.org/topics/3.8-announcement/ is dead. (404 Not Found) no-dead-link
344:106  ✓ error  https://www.encode.io/reports/march-2018 is redirected to https://www.encode.io/reports/march-2018/. (301 Moved Permanently)  no-dead-link

## docs/community/jobs.md
12:4  error  https://djangojobbers.com is dead. (403 Forbidden)
19:4  error  https://weworkcontract.com/python-contract-jobs is dead. (522 Origin Connection Time-out)

NOT FIXED:

docs/community/3.0-announcement.md
docs/community/3.2-announcement.md
13:208  error  https://www.django-rest-framework.org/topics/kickstarter-announcement/#sponsors is dead. (404 Not Found)  no-dead-link

docs/community/3.6-announcement.md
docs/community/3.7-announcement.md
docs/community/3.8-announcement.md
51:260  error    https://hello.machinalis.co.uk/ is dead. (request to https://hello.machinalis.co.uk/ failed, reason: Hostname/IP doesn't match certificate's altnames: "Host: hello.machinalis.co.uk. is not in the cert's altnames: DNS:*.numericable.fr, DNS:numericable.fr")  no-dead-link

@rpkilby
Copy link
Member

rpkilby commented Jan 2, 2019

The kickstarter announcement is now under the "community" section instead of "topics".

I think https://hello.machinalis.co.uk/ should be https://www.machinalis.com/.

@adrienbrunet
Copy link
Contributor Author

adrienbrunet commented Jan 3, 2019

I fixed the documentation with your proposals @rpkilby
Doing so, I noticed some more dead links in https://www.django-rest-framework.org/community/kickstarter-announcement/#sponsors

I corrected divio.ch to divio.com and company.onlulu.com to onlulu.com

I'm not sure all of these companies still exist:

https://singinghorsestudio.com/
pulsecode.ca (Timed out. Is it https://www.pulsecodeinc.com/ ? )
https://www.nexthub.com/?so=1 (blank page)
https://wusawork.org/ (403)

I left their links as is.

@tomchristie
Copy link
Member

Okay, shall we get this merged as-is then?
I guess the other option would be to drop the broken links completely, and just leave them as text.

@rpkilby
Copy link
Member

rpkilby commented Jan 5, 2019

I guess the other option would be to drop the broken links completely, and just leave them as text.

👍

@adrienbrunet
Copy link
Contributor Author

I remove the href="..." parts when broken. Is that okay? Should this be merged now ?
(We could use an other tag than <a> but that would mean some more css etc... Not sure it's worth it)

Tell me if I'm wrong or need any more improvements. Cheers

.... and happy new year you all. ✨ 💖 🍾

@tomchristie
Copy link
Member

Looks good to me. Thanks!

@tomchristie tomchristie merged commit 4863a24 into encode:master Jan 8, 2019
@adrienbrunet adrienbrunet deleted the doc-links branch January 8, 2019 12:08
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
* Fix links 404/302/303

* Fix machinalis links in docs

* Fix kickstarter links in documentation

* Fix kickstarter links in documentation

* Fix kickstarter links in documentation - dropping links when broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants