Use Default Version in URLPathVersioning if 'version' Didn't Specified by Client #6380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
reviewed
Jan 4, 2019
| version = kwargs.get(self.version_param, self.default_version) | ||
|
|
||
| if version is None: | ||
| version = self.default_version |
There was a problem hiding this comment.
I think it'd be marginally cleaner as:
version = kwargs.get(self.version_param)
if version is None:
version = self.default_versionNote that we're already checking for "version not in the regex groups", but we're not checking for "version is in the regex groups, but is None".
tomchristie
reviewed
Jan 4, 2019
rest_framework/versioning.py
Outdated
| e.g: | ||
| api/users/ > Use Default Version (As Often The Default Version Is The Latest One). | ||
| api/v1/users/ > Check 'v1' Is Allowed? | ||
| """ |
There was a problem hiding this comment.
On blanance I think the intent of the function is clearer from the code itself than it would be from adding this docstring.
There was a problem hiding this comment.
You right, it's unnecessary.
added 2 commits
January 5, 2019 09:54
|
Fair enough, yup. Thanks. 👍 |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
…d by Client (encode#6380) * Use Default Version in URLPathVersioning if 'version' Didn't Passed * Clean Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use default version (It's latest version as often) when 'version' is not specified by client instead of return 404 error "Invalid version in URL path.".
Closes #6379