Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing comma in documentation of permission composition #6336

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Add missing comma in documentation of permission composition #6336

merged 1 commit into from
Dec 7, 2018

Conversation

JerzySpendel
Copy link
Contributor

Comma was missing in documentation of permissions composition

@encode encode locked as too heated and limited conversation to collaborators Nov 27, 2018
@tomchristie
Copy link
Member

tomchristie commented Nov 28, 2018 •
edited
Loading

@skygate folks - Please don't do that, it's completely unnecessary.

@encode encode unlocked this conversation Nov 28, 2018
@tomchristie
Copy link
Member

Related: https://fund.django-rest-framework.org/topics/funding/

@JerzySpendel
Copy link
Contributor Author

Cool, we will consider this :)

@JerzySpendel
Copy link
Contributor Author

JerzySpendel commented Dec 7, 2018 •
edited
Loading

@tomchristie Just asking, is there any problem with this PR? It's just one-liner, if you could merge it, it would be nice :) Thanks! :)

rpkilby
rpkilby approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@rpkilby rpkilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@rpkilby rpkilby merged commit 627eeb8 into encode:master Dec 7, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Add missing comma in documentation of permission composition (encode#…
90dba25 
…6336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpkilby rpkilby rpkilby approved these changes

@Mariusz-Chrobok Mariusz-Chrobok Mariusz-Chrobok approved these changes

@natkam natkam natkam approved these changes

@KajetanDobczyk KajetanDobczyk KajetanDobczyk approved these changes

@Rafal-Maszlej Rafal-Maszlej Rafal-Maszlej approved these changes

@tomaszferens tomaszferens tomaszferens approved these changes

@python-lead python-lead python-lead approved these changes

@nomaddan nomaddan nomaddan approved these changes

@Mateusz-Slisz Mateusz-Slisz Mateusz-Slisz approved these changes

@grzegorz-bielski grzegorz-bielski grzegorz-bielski approved these changes

@wojciech-wolny wojciech-wolny wojciech-wolny approved these changes

@marcinjosinski marcinjosinski marcinjosinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet