Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in schemas #6332

Merged
merged 5 commits into from
Nov 26, 2018
Merged

Fix typo in schemas #6332

merged 5 commits into from
Nov 26, 2018

Conversation

ta7uw
Copy link
Contributor

@ta7uw ta7uw commented Nov 25, 2018

Fix typo and too long line in the documentation about schemas.

rpkilby
rpkilby approved these changes Nov 25, 2018
View reviewed changes
Copy link
Member

@rpkilby rpkilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @takaaki82 - thanks for the typo fixes. One minor suggestion - I would use parentheses for multiline strings instead of a backslash, since it's more consistently with the rest of the framework. e.g., as seen here.

@ta7uw
Copy link
Contributor Author

ta7uw commented Nov 26, 2018

@rpkilby
Thank you for the information.
I will fix the detail of your proposal content.

@rpkilby
Copy link
Member

rpkilby commented Nov 26, 2018

Thanks!

@rpkilby rpkilby merged commit 0f5dfe8 into encode:master Nov 26, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@ta7uw
Fix typo in schemas (encode#6332)
24027b0 
* Fix typo in generators.py

* Fix typo in inspectors.py

* message line too long

* Change backslash to multiline strings

* Removed trailing whitespace from assertion message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpkilby rpkilby rpkilby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ta7uw @rpkilby