FIX: openapi schema title should be a string not a tuple #6259

bpereto · 2018-10-19T16:57:05Z

Description

Introduced OpenAPI Schema renderer in 8908934 has a bug that converts schema['title'] from string to tuple.

The resulting OpenAPI Schema YAML then contains !!python/tuple, which causes apistar to fail.

       schema:
          description: A unique integer value identifying this thing.
          title: !!python/tuple
          - ID
          type: integer

stephenfin

This whole thing clearly needs a couple of unit tests, but the fix is what I've ended up with locally too.

tomchristie · 2018-11-28T12:45:23Z

👀 Thanks.

FIX: openapi schema title should be a string not a tuple

28c4d1e

stephenfin approved these changes Oct 20, 2018

View reviewed changes

albrugnetti mentioned this pull request Nov 27, 2018

OpenAPIRenderer parameter title #6334

Closed

tomchristie merged commit 5a54f89 into encode:master Nov 28, 2018

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020

FIX: openapi schema title should be a string not a tuple (encode#6259)

8b42880

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIX: openapi schema title should be a string not a tuple #6259

FIX: openapi schema title should be a string not a tuple #6259

bpereto commented Oct 19, 2018

stephenfin left a comment

tomchristie commented Nov 28, 2018

FIX: openapi schema title should be a string not a tuple #6259

FIX: openapi schema title should be a string not a tuple #6259

Conversation

bpereto commented Oct 19, 2018

Description

stephenfin left a comment

Choose a reason for hiding this comment

tomchristie commented Nov 28, 2018