Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shapely #604

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add shapely #604

wants to merge 7 commits into from

Conversation

jsignell
Copy link

@jsignell jsignell commented Aug 2, 2023

Similar to #603: copying from: conda-forge and pyodide

@jsignell jsignell mentioned this pull request Aug 2, 2023
@martinRenou
Copy link
Contributor

I realize there was already a PR attempt adding shapely and geos in #131

Maybe you could take some inspiration from there? Probably you can ignore the changes in .github/workflows/build_recipes.yaml and conda_build_config.yml there.

Also it may be a good idea to add both recipes at the same time, that way you can test that shapely actually works with the geos you are building.

@jsignell
Copy link
Author

jsignell commented Aug 3, 2023

Oh man! I think I looked for issues but not PRs 🤦 let me check. There was a big change in shapely 2.0 (released December 2022) that made it easier to build: https://shapely.readthedocs.io/en/stable/release/2.x.html#refactor-of-the-internals so the build process might be significantly different than it was when that PR was opened.

@jsignell jsignell mentioned this pull request Aug 4, 2023
trying with fixed src dir
@DerThorsten
Copy link
Contributor

might work with #609

@DerThorsten DerThorsten mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants