Skip to content

Commit

Permalink
chore(ext/http): fix E0446 on some compiler versions (denoland#21362)
Browse files Browse the repository at this point in the history
Rust 1.74 may have made this code temporarily valid in [#113126 Replace
old private-in-public diagnostic with type privacy
lints](rust-lang/rust#113126), so we didn't
catch it at build time.

It fails in 1.73 and +nightly, however.
  • Loading branch information
mmastrac committed Nov 27, 2023
1 parent 3e83d68 commit 8ce4ddc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ deno_crypto = { version = "0.139.0", path = "./ext/crypto" }
deno_fetch = { version = "0.149.0", path = "./ext/fetch" }
deno_ffi = { version = "0.112.0", path = "./ext/ffi" }
deno_fs = { version = "0.35.0", path = "./ext/fs" }
deno_http = { version = "0.121.0", path = "./ext/http" }
deno_http = { version = "0.122.0", path = "./ext/http" }
deno_io = { version = "0.35.0", path = "./ext/io" }
deno_net = { version = "0.117.0", path = "./ext/net" }
deno_node = { version = "0.62.0", path = "./ext/node" }
Expand Down
2 changes: 1 addition & 1 deletion ext/http/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[package]
name = "deno_http"
version = "0.121.0"
version = "0.122.0"
authors.workspace = true
edition.workspace = true
license.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion ext/http/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ impl Drop for HttpRequestBodyAutocloser {
}
}

pub async fn handle_request(
pub(crate) async fn handle_request(
request: Request,
request_info: HttpConnectionProperties,
server_state: SignallingRc<HttpServerState>, // Keep server alive for duration of this future.
Expand Down

0 comments on commit 8ce4ddc

Please sign in to comment.