add serializer file #777
Merged
add serializer file #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatown
reviewed
Jul 26, 2018
packages/jest-emotion/serializer.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| const { createSerializer } = require('./dist') | |||
There was a problem hiding this comment.
Could you change this to requiring jest-emotion instead of ./dist?
There was a problem hiding this comment.
Interesting! Will that work!?
There was a problem hiding this comment.
Yeah, node should look in the node_modules folder, go into the jest-emotion folder and look at the main property in the package.json.
|
Thanks @kentcdodds |
|
Awesome! just what I needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This adds a root-level
serializer.jsfileWhy: It will make it much easier to use this package for the common use-case. People will be able to configure the serializer using the
snapshotSerializersconfig:{ "snapshotSerializers": [ "jest-emotion/serializer" ] }How: Created a new file called
serializer.jsin the root of the project that simply creates the serializer as documented.Checklist: