No duplicated ast nodes #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
force-pushed
the
no-duplicated-ast-nodes
branch
from
7875276
to
4ea1682
Compare
Andarist
commented
Jun 17, 2018
| @@ -25,38 +26,43 @@ jest.mock('fs') | |||
| fs.existsSync.mockReturnValue(true) | |||
| fs.statSync.mockReturnValue({ isFile: () => false }) | |||
|
|
|||
| const createInlineTester = transform => opts => { | |||
| const isBabel7 = babel => parseInt(babel.version.split('.')[0], 10) === 7 | |||
There was a problem hiding this comment.
babel@6 duplicates some nodes, so we just want to validate this when using babel@7 to avoid false positives caused by babel itself
Andarist
force-pushed
the
no-duplicated-ast-nodes
branch
4 times, most recently
from
e1576bd
to
d0d53aa
Compare
Codecov Report
|
Andarist
force-pushed
the
no-duplicated-ast-nodes
branch
from
d0d53aa
to
936155b
Compare
|
@mitchellhamilton done |
…ith registry.yarnpkg.com in yarn.lock
|
@mitchellhamilton as to the registry change - I couldn't install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
fixes #726