Add Typescript definitions for 'create-emotion-server' and 'emotion-server' #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bad857d
to
45c8dff
Compare
|
Please update |
tkh44
approved these changes
Jun 4, 2018
Ailrun
reviewed
Jun 4, 2018
| "rules": { | ||
| "no-relative-import-in-test": false | ||
| } | ||
| } |
There was a problem hiding this comment.
You miss the final linefeeding for this file
There was a problem hiding this comment.
There are many more tslint.json files without this line feed. Do you want me to add them to those as well?
Edit: I went ahead and did it anyway
Ailrun
reviewed
Jun 4, 2018
| @@ -20,8 +23,10 @@ | |||
| "emotion": "^9.1.3" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/react-dom": "16.0.5", | |||
There was a problem hiding this comment.
It should depend on @types/react-dom as dependencies, or, at least as peerDependencies, shouldn't it?
There was a problem hiding this comment.
The only use is inside the tests so I don't think it should.
There was a problem hiding this comment.
@mgroenhoff Oh, you're right. My miss.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Typescript definitions added for
create-emotion-serverandemotion-serverWhy: Because Typescript!
How:
Checklist: