Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for invalid content values in objects #633

Merged
merged 1 commit into from
Apr 21, 2018
Merged

Add warning for invalid content values in objects #633

merged 1 commit into from
Apr 21, 2018

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Apr 21, 2018 •
edited

What:
Add warning for invalid content values

Why:

Seeing px as the value for content when you pass '' is confusing.

How:

Add a dev warning that checks for invalid content values using some logic from here

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@codecov
Copy link

codecov bot commented Apr 21, 2018 •
edited

Codecov Report

Merging #633 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/create-emotion/src/utils.js 100% <100%> (ø) ⬆️

@emmatown emmatown requested a review from tkh44 April 21, 2018 02:11
@emmatown emmatown mentioned this pull request Apr 21, 2018
Closed
@tkh44
Copy link
Member

tkh44 commented Apr 21, 2018

This is really great DX. Awesome idea!

@tkh44 tkh44 merged commit 9f8cd60 into master Apr 21, 2018
@emmatown emmatown deleted the warning-for-invalid-content-values branch July 6, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkh44 tkh44 Awaiting requested review from tkh44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emmatown @tkh44