Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Website Development to CONTRIBUTING.md #577

Merged
merged 2 commits into from
Feb 20, 2018

Conversation

azizhk
Copy link
Contributor

@azizhk azizhk commented Feb 20, 2018

Just few updates based on #576 (comment)

CONTRIBUTING.md Outdated
- Running `yarn` in the module's root directory will install everything you need for development.
- Run `lerna bootstrap` in the module's root directory
- Run `yarn` in the module's root directory to install everything you need for development.
- Run `yarn build` in the root directory to build the modules and handle interlinking.
Copy link
Member

@emmatown emmatown Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the handle interlinking bit since building doesn't do any linking?

@emmatown emmatown merged commit b3fc6f8 into emotion-js:master Feb 20, 2018
@emmatown
Copy link
Member

Thanks!!

@azizhk azizhk deleted the patch-1 branch February 20, 2018 09:45
@tkh44
Copy link
Member

tkh44 commented Feb 21, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants