Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to babel-plugin-macros #525

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jan 9, 2018

I didn't do extensive testing, but the tests pass and @kentcdodds said there were no breaking changes…

fixes #515

What: changed babel-macros to babel-plugin-macros

Why: this is the new name and the one that is going to be incorporated in CRA

How: pretty much find and replace babel-macros for babel-plugin-macros

Checklist:

  • Documentation
  • Tests
  • Code complete

@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 9, 2018

The tests completely fail on my end because eslint (prettier) expects trailing commas, while they seem to be explicitly forbidden over the code base

Haroenv added a commit to Haroenv/emotion that referenced this pull request Jan 9, 2018
1. ran `yarn eslint . --fix`
2. ran `yarn jest -u` (trailing commas changed snapshots)

see emotion-js#525 (comment)
@tkh44
Copy link
Member

tkh44 commented Jan 9, 2018

Thanks @Haroenv I'll look at that right now.

@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 9, 2018

tests are failing on CI because of unrelated linting, AFAICT #526 should fix that

Haroenv added a commit to Haroenv/emotion that referenced this pull request Jan 9, 2018
1. ran `yarn eslint . --fix`
2. ran `yarn jest -u` (trailing commas changed snapshots)

see emotion-js#525 (comment)
I didn't do __extensive__ testing, but the tests pass and @kentcdodds said there were no breaking changes…

fixes emotion-js#515
@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 9, 2018

voilà, now without the accidental trailing commas @tkh44 🤷‍♂️

@tkh44 tkh44 merged commit d7076e7 into emotion-js:master Jan 9, 2018
@tkh44
Copy link
Member

tkh44 commented Jan 9, 2018

Thanks again

@Haroenv Haroenv deleted the chore/babel-plugin-emotion branch January 9, 2018 21:10
@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 9, 2018

With pleasure, glad @kentcdodds made it such a smooth upgrade path

@tkh44
Copy link
Member

tkh44 commented Jan 9, 2018

Is there anything else you would like to release with this @mitchellhamilton? Should we backport this to 8? or just run with putting it in 9?

@Haroenv
Copy link
Contributor Author

Haroenv commented Jan 9, 2018

I just saw the commit message said emotion, but that should have been macros

@emmatown
Copy link
Member

emmatown commented Jan 9, 2018

@tkh44 Let's just put it in 9 since AFAIK macros built with babel-macros are compatible with babel-plugin-macros.

Maybe @kentcdodds can correct me if I'm wrong?

We could do a release now with this and #516 to next.

@emmatown emmatown changed the title chore: upgrade to babel-plugin-emotion chore: upgrade to babel-plugin-macros Jan 9, 2018
@kentcdodds
Copy link
Contributor

Yes, it should actually be totally compatible. All macros using babel-macros to be created should work with the babel-plugin-macros transform because the creation just sets a few properties on your function so it should work :)

@stereobooster stereobooster mentioned this pull request Jan 29, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to babel-plugin-macros
4 participants