Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styles getting injected in the classname (#492) #500

Merged
merged 2 commits into from
Dec 21, 2017
Merged

Fix styles getting injected in the classname (#492) #500

merged 2 commits into from
Dec 21, 2017

Conversation

pimmey
Copy link
Contributor

@pimmey pimmey commented Dec 21, 2017 •
edited
Loading

What: Fixes #492

Why: It was a bug

How: By changing the pattern of the label and covering it with a test

Checklist:

  • Documentation
  • Tests
  • Code complete

@emmatown emmatown changed the title Styles are getting injected in the classname (#492) Fix styles getting injected in the classname (#492) Dec 21, 2017
emmatown
emmatown approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@codecov
Copy link

codecov bot commented Dec 21, 2017 •
edited
Loading

Codecov Report

Merging #500 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/emotion/src/index.js 100% <100%> (ø) ⬆️

@emmatown emmatown merged commit 2f774e6 into emotion-js:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styles are getting injected in the classname
2 participants
@pimmey @emmatown