Do not add px to css custom-properties #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
emmatown
reviewed
Nov 29, 2017
packages/emotion/src/index.js
Outdated
| if (unitless[key] !== 1 && !isNaN(value) && value !== 0) { | ||
| if ( | ||
| unitless[key] !== 1 && | ||
| key.indexOf('--') !== 0 && |
There was a problem hiding this comment.
Could you change this to key.charCodeAt(1) !== 45(45 is the char code for -) since this is a very hot path and charCodeAt is much faster.
There was a problem hiding this comment.
Do you mean checking both first two chat codes?
There was a problem hiding this comment.
No, there's no need to since there are no regular css properties with a dash as the second character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #479
What:
Bug
Why:
To support css custom properties which can be used to simplify cascade
How:
Just added special case with checking keys started with
--Checklist: