Add more context to the styled component displayName #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatown
reviewed
Sep 30, 2017
packages/react-emotion/src/index.js
Outdated
| Styled.contextTypes = contextTypes | ||
|
|
||
| Styled.__emotion_styles = styles | ||
| Styled.__emotion_base = baseTag | ||
| Styled.__emotion_real = Styled | ||
|
|
||
| Styled.displayName = `Styled(${typeof baseTag === 'string' | ||
| ? baseTag | ||
| : baseTag.displayName || 'Component'})` |
There was a problem hiding this comment.
Should baseTag.name also be here?
There was a problem hiding this comment.
Not sure where name comes from.
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 97.73% 97.74% +<.01%
==========================================
Files 22 22
Lines 663 664 +1
Branches 151 152 +1
==========================================
+ Hits 648 649 +1
Misses 11 11
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add the base_tag displayName to the styled component
Why:
So they show up in React dev tools.
#358
How:
Append the property
Checklist:
closes #358