Handle boolean values #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 22 22
Lines 662 662
Branches 152 152
=======================================
Hits 647 647
Misses 11 11
Partials 4 4
Continue to review full report at Codecov.
|
emmatown
reviewed
Sep 30, 2017
packages/emotion/src/index.js
Outdated
| @@ -120,6 +120,7 @@ function handleInterpolation( | |||
| if ( | |||
| interpolation === undefined || | |||
| interpolation === null || | |||
| interpolation === false || | |||
| typeof value === 'boolean' | |||
There was a problem hiding this comment.
I think this should be typeof interpolation === 'boolean'.
There was a problem hiding this comment.
@tkh44 The typeof value === 'boolean' can also be removed, I must've wrote value instead of interpolation by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Literal false values were tripping up the parser.
Why:
We were checking undefined and null but not false.
How:
Add explicit false check.
Checklist: