Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component selectors #334

Merged
merged 8 commits into from
Sep 25, 2017
Merged

Remove component selectors #334

merged 8 commits into from
Sep 25, 2017

Conversation

tkh44
Copy link
Member

@tkh44 tkh44 commented Sep 25, 2017

What:
Close #329

Why:

The idea is neat, but the amount of code and effort required (maintenance) do not meet its utility.

The babel plugin is no longer required for basic usage.*

* the plugin enables the following features

  • styled.div syntax (styled('div') will work without the plugin)
  • minification
  • /*#__PURE__*/ flag injection
  • static extraction
  • source maps

Checklist:

  • Documentation
  • Tests
  • Code complete

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

Merging #334 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage    97.3%   97.27%   -0.03%     
==========================================
  Files          17       17              
  Lines         593      551      -42     
  Branches      142      130      -12     
==========================================
- Hits          577      536      -41     
+ Misses         12       11       -1     
  Partials        4        4
Impacted Files Coverage Δ
packages/react-emotion/src/index.js 100% <100%> (ø) ⬆️
packages/babel-plugin-emotion/src/index.js 94% <100%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5283d...ed686d4. Read the comment docs.

@tkh44 tkh44 merged commit bb383f4 into master Sep 25, 2017
@tkh44 tkh44 deleted the remove-component-selectors branch September 25, 2017 02:26
@emmatown emmatown mentioned this pull request Nov 24, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Remove Component As Selector
2 participants