Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cross-env to pass env vars across platforms #327

Merged
merged 3 commits into from
Sep 25, 2017
Merged

Use cross-env to pass env vars across platforms #327

merged 3 commits into from
Sep 25, 2017

Conversation

apostolos
Copy link
Contributor

What: Fix test & build scripts in Windows

Why: rollup UMD builds need UMD=true to be set as an environment variable. This breaks test & build scripts on Windows machines making it hard for people to contribute.

How: Adds cross-env which takes care of differences to setting and using environment variables across platforms.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete N/A

Only tested this in Windows and Linux. I don't currently have access to an OSX machine.

@codecov
Copy link

codecov bot commented Sep 22, 2017

Codecov Report

Merging #327 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          17       17           
  Lines         562      562           
  Branches      133      133           
=======================================
  Hits          547      547           
  Misses         11       11           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c4a40...733974f. Read the comment docs.

@tkh44
Copy link
Member

tkh44 commented Sep 22, 2017

I can test this more tonight. Thank you for taking the time to help others @apostolos

@tkh44 tkh44 merged commit a10c74e into emotion-js:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants