Ensure proper insert order of nested rules & atRules #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2017 13:52
emmatown
reviewed
Sep 21, 2017
There was a problem hiding this comment.
I was originally planning to do this but the insert order problem affects nested selectors as well as media queries. https://codesandbox.io/s/p5ymkr9n0
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 96.29% 96.37% +0.08%
==========================================
Files 16 16
Lines 567 580 +13
Branches 138 141 +3
==========================================
+ Hits 546 559 +13
Misses 16 16
Partials 5 5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
How:
Here is where I played around with this idea. https://codesandbox.io/s/kxxvqxrxnv
Checklist: