Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel-plugin-codegen to generate props regex #304

Merged
merged 2 commits into from
Sep 13, 2017

Conversation

emmatown
Copy link
Member

What:

Use babel-plugin-codegen to generate the props filter regex instead of babel-plugin-preval.

Why:

So that a regex literal is used instead of a string and then new RegExp()

How:

Use codegen.require and change preval to codegen in all the babel configs

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete

@codecov
Copy link

codecov bot commented Sep 13, 2017

Codecov Report

Merging #304 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   90.45%   90.45%           
=======================================
  Files          21       21           
  Lines         974      974           
  Branches      261      261           
=======================================
  Hits          881      881           
  Misses         75       75           
  Partials       18       18
Impacted Files Coverage Δ
packages/react-emotion/src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a58f9...a09bec1. Read the comment docs.

@emmatown emmatown merged commit 4265a72 into master Sep 13, 2017
@emmatown emmatown deleted the codegen-props-regex branch September 13, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant