Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rollup config #280

Merged
merged 3 commits into from
Aug 22, 2017
Merged

Change rollup config #280

merged 3 commits into from
Aug 22, 2017

Conversation

emmatown
Copy link
Member

What:

  • Remove all the individual rollup configs and create a single one in the root directory
  • Add babel-plugin-transform-es2015-typeof-symbol to babel-preset-env excludes

Why:

Because there was lots of duplication and if we wanted to change the babel config we had to go to every rollup config and change it.

I removed babel-plugin-transform-es2015-typeof-symbol because we aren't checking if something is a symbol so it adds a useless helper.

How:

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete

@codecov-io
Copy link

codecov-io commented Aug 22, 2017

Codecov Report

Merging #280 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   90.37%   90.37%           
=======================================
  Files          21       21           
  Lines         966      966           
  Branches      260      260           
=======================================
  Hits          873      873           
  Misses         75       75           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4bd7d3...89b7d77. Read the comment docs.

@tkh44 tkh44 merged commit 4d110f4 into master Aug 22, 2017
@tkh44 tkh44 deleted the change-rollup-config branch August 22, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants