add docs for using withProps from recompose #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 21 21
Lines 966 966
Branches 260 260
=======================================
Hits 873 873
Misses 75 75
Partials 18 18Continue to review full report at Codecov.
|
|
Sorry for taking so long with this. |
quantizor
reviewed
Aug 22, 2017
docs/with-props.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| ## Usage with recompose's withProps | |||
|
|
|||
| You can pass additional props to your components using recompose's `withProps` higher-order component. The `withProps` api is laid out [here](https://github.com/acdlite/recompose/blob/master/docs/API.md#withprops). | |||
There was a problem hiding this comment.
"here" isn't a very accessible anchor link - perhaps it could be "in the recompose documentation" instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added documentation for using emotion with the
withPropsHOC from recompose.Why:
#111
How:
I added a
with-props.mdfile to the docs folder.Checklist:
I wasn't sure how many examples to include or how in-depth to make them so I kept it really simple for now. I also wasn't entirely sure of what to name the new doc file so I tentatively went with
with-props.md.