Makefiles rework #47
Merged
Makefiles rework #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corteccia
force-pushed
the
makefiles-relative-paths
branch
from
7ead50b
to
fccd11f
Compare
corteccia
force-pushed
the
makefiles-relative-paths
branch
3 times, most recently
from
45eb49a
to
b0e037d
Compare
It's better to exclude relative paths, i.e. building examples via one Makefile. Thus there's no need to keep source files in separate dirs.
corteccia
force-pushed
the
makefiles-relative-paths
branch
from
b0e037d
to
298ed58
Compare
corteccia
force-pushed
the
makefiles-relative-paths
branch
from
298ed58
to
c98122b
Compare
AlexanderDranitsa
approved these changes
May 21, 2021
corteccia
force-pushed
the
makefiles-relative-paths
branch
from
83ee786
to
323675c
Compare
In case to get rid of relative paths and make it more easy to use, it's better to use top-level Makefile for building all the libraries and examples at once and not finding executables in several directories. All the executables will be stored in Build dir.
We don't need to clean pigpio if it's installed on RPi since it wouldn't be updated as submodule and it will produce an error.
corteccia
force-pushed
the
makefiles-relative-paths
branch
from
323675c
to
d70bf0e
Compare
AlexeyBulatov
approved these changes
May 24, 2021
|
Well done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I rework some Makefiles for C++ examples. I removed all the individual Makefiles for Examples and moved them into one dir, now all .cpp files in Examples dir. Instead of individual Makefiles, I made one top-level Makefile which would compile libraries first and then all the source files in Examples into directory Build. This should solve the problem with relative paths and simplify the use of the repository for users.
So the user can now build all the libraries and examples by running
makefrom the C++ folder. But there is no way to build just one example.What do you think?