C++: change compiler variables to simplify cross-compilation #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staroselskii
suggested changes
Apr 20, 2020
There was a problem hiding this comment.
Thank you for your PR!
Could you please elaborate on what kind of issues you had?
"C++: all: Makefile: change CXX to optional" doesn't really represent what is going on in this commit.
You're actually not only making CXX optional but also changing CC to CXX in some examples. Please, add more context to the commit message.
corteccia
force-pushed
the
pr-cross-compilation-fix
branch
from
e13f348
to
bd2e075
Compare
|
Change commit message. Is it more understandable now? |
corteccia
changed the title
corteccia
force-pushed
the
pr-cross-compilation-fix
branch
from
bd2e075
to
d18e648
Compare
Some C++ examples could not be cross-compiled for RPi using export CXX=arm-linux-gnueabihf-g++ because some compiler variables could not be set from outside or were compiled with C compiler. After this change, all examples will be compiled with C++ compiler that can be overridden with an environment variable set to the cross-compiler. This commit doesn't make everything cross-compile as there's a dependency on pigpio library that should be addressed in other commits.
corteccia
force-pushed
the
pr-cross-compilation-fix
branch
from
d18e648
to
e6ef6af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I tried to cross-compiled and got some errors:
ld returned 1 exit status,make: Command not found, or just compiled using g++, not cross-compiler.In order to fix this I suggest this change.
Even though it doesn't fix everything (there's still dependency on pigpio library that can't just be installed on host machine), it's better.
After applying this change and compiling with
arm-linux-gnueabihf-g++you'll get errors with RCInput_Navio.cpp that has a dependency on pigpio.h. I would try to handle with it in other commits.