Add support for changing ublox rate (c++) #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorAnohin
force-pushed
the
pr-change-ublox-rate-cpp-support
branch
3 times, most recently
from
4c270a8
to
e7678ad
Compare
staroselskii
suggested changes
Jul 10, 2018
C++/Navio/Common/Ublox.cpp
Outdated
|
|
||
| int Ublox::_sendMessage(std::uint8_t msg_class, std::uint8_t msg_id, void *msg, std::uint16_t size) | ||
| { | ||
| unsigned char buffer[buffer_length]; |
There was a problem hiding this comment.
it's a const. Make it UBX_BUFFER_LENGTH
C++/Navio/Common/Ublox.cpp
Outdated
| return SPIdev::transfer(spi_device_name.c_str(), buffer, nullptr, offset, 200000); | ||
| } | ||
|
|
||
| int Ublox::_spliceMemory(unsigned char *dest, const void *src, std::size_t size, int dest_offset) |
C++/Navio/Common/Ublox.cpp
Outdated
| return dest_offset + size; | ||
| } | ||
|
|
||
| Ublox::CheckSum Ublox::_calculateCheckSum(unsigned char message[], std::size_t size) { |
There was a problem hiding this comment.
unsigned char *message is more conventional
C++/Navio/Common/Ublox.h
Outdated
| #include <vector> | ||
| #include <list> |
There was a problem hiding this comment.
Looks like a left-over
There was a problem hiding this comment.
Yes, you're right.
IgorAnohin
force-pushed
the
pr-change-ublox-rate-cpp-support
branch
from
e7678ad
to
0a11868
Compare
added 2 commits
July 11, 2018 16:24
Add function configureSolutionRate for changing Ublox rate Also add function for calculating check summs and adding ublox prefix
IgorAnohin
force-pushed
the
pr-change-ublox-rate-cpp-support
branch
from
0a11868
to
2d27427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.