Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix egui_glow when targeting wasm32-unknown-unknown #1303

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Fix egui_glow when targeting wasm32-unknown-unknown #1303

merged 3 commits into from
Mar 7, 2022

Conversation

Jake-Shadle
Copy link
Contributor

@Jake-Shadle Jake-Shadle commented Feb 25, 2022 •
edited
Loading

This fixes compilation failures when targeting wasm32-unknown-unknown with eframe when the egui_glow or persistence feature flags are enabled. This adds a CI check to prevent this in the future.

See the puffin action failure

@DusterTheFirst
Copy link
Contributor

This compilation failure seems to only arise when using cargo resolver v1 in my experience. If this issue matches the one in #1307, merging this will close #1307

@DusterTheFirst DusterTheFirst mentioned this pull request Feb 25, 2022
Closed
@emilk emilk merged commit 37c9f11 into emilk:master Mar 7, 2022
@emilk
Copy link
Owner

emilk commented Mar 7, 2022

Thanks!

Titaniumtown added a commit to Titaniumtown/egui that referenced this pull request Mar 7, 2022
@Titaniumtown
Revert "Fix egui_glow when targeting wasm32-unknown-unknown (emilk#…
fa51067 
…1303)"

This reverts commit 37c9f11.
emilk added a commit that referenced this pull request Mar 8, 2022
@emilk
Fix cargo run -p egui_demo_app
468ce14 
Broken by #1303
@emilk emilk mentioned this pull request Mar 8, 2022
Merged
emilk added a commit that referenced this pull request Mar 8, 2022
@emilk
Fix cargo run -p egui_demo_app (#1343)
d830003 
Broken by #1303
@simon-frankau simon-frankau mentioned this pull request Apr 26, 2024
Closed
simon-frankau added a commit to simon-frankau/egui that referenced this pull request Apr 26, 2024
@simon-frankau
Enable egui_glow's winit feature on wasm (emilk#4420)
5cf8951 
Reverts change in emilk#1303, enabling the egui_glow::winit module when
using wasm.
@simon-frankau simon-frankau mentioned this pull request Apr 26, 2024
Merged
emilk pushed a commit that referenced this pull request Apr 29, 2024
@simon-frankau
Enable egui_glow's winit feature on wasm (#4420) (#4421)
c1fc921 
Reverts change in #1303, enabling the egui_glow::winit module when using
wasm.

* Closes <#4420>
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@simon-frankau @hacknus
Enable egui_glow's winit feature on wasm (emilk#4420) (emilk#4421)
f66651a 
Reverts change in emilk#1303, enabling the egui_glow::winit module when using
wasm.

* Closes <emilk#4420>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jake-Shadle @DusterTheFirst @emilk