Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort on escape #25

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Abort on escape #25

merged 3 commits into from
Feb 13, 2019

Conversation

yorickvP
Copy link
Collaborator

This looked doable. Is any more bookkeeping needed? maybe a wl_keyboard_destroy somewhere?

@emersion
Copy link
Owner

maybe a wl_keyboard_destroy somewhere?

Yeah, we need to keep track of keyboards, just like pointers and seats.

I think it would make sense to merge slurp_pointer and slurp_seat together, since there is always at most one pointer per seat. Then we could add the keyboard state to the seat as well.

@yorickvP yorickvP mentioned this pull request Feb 12, 2019
Merged
emersion
emersion reviewed Feb 13, 2019
View reviewed changes
include/slurp.h Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 13, 2019
View reviewed changes
main.c Outdated Show resolved Hide resolved
emersion
emersion reviewed Feb 13, 2019
View reviewed changes
main.c Outdated Show resolved Hide resolved
emersion
emersion requested changes Feb 13, 2019
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise :)

emersion
emersion approved these changes Feb 13, 2019
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersion emersion merged commit 11cdf77 into emersion:master Feb 13, 2019
@emersion
Copy link
Owner

Thanks!

@yorickvP yorickvP deleted the esc branch February 13, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorickvP @emersion