Explicitly set the default for span creation to non-private

[bidetofevil]

Goal

Make interfaces default to creating spans that are non-private. This is already the case for the create and start span APIs, but the other methods still defaulted to pairing private with internal, which can be confusing.

In practice, the only change is that network request spans are now non-private, which they should've been anyway. All other changes are removing explicit parameters that match the default, which doesn't change existing behaviour

Testing

Modified existing tests to verify the default. Did not add additional tests for network spans because that's just using the default now.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[bidetofevil]

• Explicitly set the default for span creation to non-private #998 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (42639be) to head (1e3eeac).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #998   +/-   ##
=======================================
  Coverage   78.99%   79.00%           
=======================================
  Files         416      416           
  Lines       11052    11045    -7     
  Branches     1764     1764           
=======================================
- Hits         8731     8726    -5     
+ Misses       1540     1538    -2     
  Partials      781      781           

Files	Coverage Δ
...bracesdk/capture/startup/AppStartupTraceEmitter.kt	70.16% <ø> (-1.04%)	⬇️
...id/embracesdk/internal/spans/EmbraceSpanFactory.kt	100.00% <ø> (ø)
...android/embracesdk/internal/spans/EmbraceTracer.kt	96.96% <100.00%> (+0.41%)	⬆️
...e/android/embracesdk/internal/spans/SpanService.kt	96.87% <100.00%> (ø)
...esdk/internal/spans/UninitializedSdkSpanService.kt	75.00% <100.00%> (+1.98%)	⬆️
...dk/network/logging/EmbraceNetworkLoggingService.kt	96.42% <ø> (-0.13%)	⬇️