Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings #978

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix build warnings #978

merged 1 commit into from
Jun 21, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jun 20, 2024

Goal

Resolve miscellaneous compiler warnings , mostly about deprecated method usage. Made changes to proper methods, or added suppression annotation regarding the use of our own deprecated enum LogType.

Testing

Existing tests cover these changes

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

@bidetofevil bidetofevil marked this pull request as ready for review June 20, 2024 17:00
@bidetofevil bidetofevil requested a review from a team as a code owner June 20, 2024 17:00
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.94%. Comparing base (7a41765) to head (1b06cd0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #978   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files         444      444           
  Lines       11809    11809           
  Branches     1802     1802           
=======================================
  Hits         9559     9559           
  Misses       1455     1455           
  Partials      795      795           
Files Coverage Δ
...d/embracesdk/capture/startup/StartupServiceImpl.kt 100.00% <100.00%> (ø)
...ernal/api/delegate/EmbraceInternalInterfaceImpl.kt 83.82% <ø> (ø)
.../delegate/UninitializedSdkInternalInterfaceImpl.kt 64.70% <ø> (ø)
...l/network/http/EmbraceUrlStreamHandlerFactory.java 46.15% <100.00%> (ø)
...k/internal/api/delegate/ViewTrackingApiDelegate.kt 41.17% <0.00%> (ø)

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil merged commit 7ae6904 into master Jun 21, 2024
4 checks passed
@bidetofevil bidetofevil deleted the hho/fix-build-warnings branch June 21, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants