Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify end time for in progress anrs #923

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Jun 5, 2024

Goal

Specifies an end time for ANRs that are in-progress if one does not already exist. Ordinarily the OTel infrastructure would take care of this, but we've chosen to go outside of that for ANRs.

Testing

Updated unit test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner June 5, 2024 13:18
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.71%. Comparing base (37dbdce) to head (6464918).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           style-updates     #923      +/-   ##
=================================================
- Coverage          80.75%   80.71%   -0.05%     
=================================================
  Files                436      436              
  Lines              11606    11607       +1     
  Branches            1777     1777              
=================================================
- Hits                9373     9369       -4     
- Misses              1446     1448       +2     
- Partials             787      790       +3     
Files Coverage Δ
...io/embrace/android/embracesdk/anr/AnrOtelMapper.kt 87.17% <100.00%> (ø)
.../android/embracesdk/anr/ndk/NativeAnrOtelMapper.kt 77.58% <100.00%> (+0.39%) ⬆️
.../embrace/android/embracesdk/injection/AnrModule.kt 96.49% <100.00%> (ø)
.../io/embrace/android/embracesdk/ndk/NativeModule.kt 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It really feels like we should find a nice way to handling cases like this, e.g. send a bunch of telemetry to a holding area to give us a chance to redact logged telemetry, then "release" them when we're done. Building some plumbing around that feels like a reasonable thing to do for mobile apps

Base automatically changed from style-updates to integration/v2-migration June 6, 2024 08:53
@fractalwrench fractalwrench merged commit 9eb46ed into integration/v2-migration Jun 6, 2024
3 checks passed
@fractalwrench fractalwrench deleted the anr-end-time branch June 6, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants