Remove old implementation of Crashes #921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the legacy way of handling crashes for Embrace. We now use CrashDataSource, which will add the crashes to the current session span and emit an OTel log.
This allowed us to use the legacy or the new crashes implementation, depending on a config flag (
configService.oTelBehavior.isBetaEnabled()
).Most importantly, it registered the EmbraceUncaughtExceptionHandler when the class was initialized. This was moved to the CrashDataSourceImpl.
Questions: