Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing deprecated start methods #904

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented May 29, 2024

Goal

Remove tests for deprecated start method so the compiler doesn't yell at me.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

@bidetofevil bidetofevil marked this pull request as ready for review May 29, 2024 21:16
@bidetofevil bidetofevil requested a review from a team as a code owner May 29, 2024 21:16
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (e5bf3de) to head (a94b46f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   80.83%   80.93%   +0.09%     
==========================================
  Files         436      436              
  Lines       11628    11628              
  Branches     1773     1773              
==========================================
+ Hits         9400     9411      +11     
+ Misses       1443     1434       -9     
+ Partials      785      783       -2     

see 6 files with indirect coverage changes

@bidetofevil bidetofevil merged commit 56a4649 into master May 30, 2024
4 checks passed
@bidetofevil bidetofevil deleted the hho/deprecated-start branch May 30, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants