Use new sdk time direcctly and indirectly for timetamps sent in SDK #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
bidetofevil
force-pushed
the
hho/use-sdk-time
branch
from
8dd1aaa
to
5f7c4a1
Compare
bidetofevil
force-pushed
the
hho/internal-interface
branch
from
a5fae6f
to
924a37b
Compare
bidetofevil
force-pushed
the
hho/use-sdk-time
branch
from
5f7c4a1
to
5db8dae
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## hho/internal-interface #9 +/- ##
==========================================================
- Coverage 72.74% 72.73% -0.01%
==========================================================
Files 306 306
Lines 9987 9988 +1
Branches 1440 1440
==========================================================
Hits 7265 7265
- Misses 2153 2154 +1
Partials 569 569
|
bidetofevil
requested review from
fractalwrench,
fnewberg and
a team
as code owners
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Either use the SDK time directly when we control the source of the timestamp used for logging network requests, or use to calculate an offset to apply to the system time (used by OkHttp for instance) so that it lines up more or less with the time the SDK uses.
Testing
Added to the component tests for both network stacks to verify the time is as expected