Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove process listening from user service #89

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes an unnecessary listener - the user service does not implement the onForeground/onBackground callbacks so doesn't need to implement this interface.

@fractalwrench fractalwrench requested a review from a team as a code owner November 17, 2023 14:10
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #89 (964cfd7) into master (7b2e011) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   76.02%   76.01%   -0.01%     
==========================================
  Files         314      314              
  Lines       10076    10076              
  Branches     1457     1457              
==========================================
- Hits         7660     7659       -1     
- Misses       1827     1828       +1     
  Partials      589      589              
Files Coverage Δ
...roid/embracesdk/capture/user/EmbraceUserService.kt 70.17% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit e49df69 into master Nov 20, 2023
4 checks passed
@fractalwrench fractalwrench deleted the remove-process-listener branch November 20, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants