Simplify CountingInputstreamWithCallback and remove unnecessary constructs

[bidetofevil]

Goal

Simplified implementation of the wrapped stream to not return the bytes in the callback. This could probably be furthered simplified to not count bytes, but there's some logic there involving stream marking and reseting that I don't fully grok yet, so I'd rather not touch it.

I've also removed a couple of backwards compatible constructs that aren no longer necessary.

Testing

Existing tests pass.

[bidetofevil]

Current dependencies on/for this PR:

• master
  • PR Use the over-the-wire response size when logging URLConnection network calls #85
    • PR Simplify CountingInputstreamWithCallback and remove unnecessary constructs #86 👈

This stack of pull requests is managed by Graphite.

[codecov]

Codecov Report

Merging #86 (22b981f) into hho/response-size (0dfc038) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@                Coverage Diff                 @@
##           hho/response-size      #86   +/-   ##
==================================================
  Coverage              76.02%   76.03%           
==================================================
  Files                    313      313           
  Lines                  10095    10096    +1     
  Branches                1454     1454           
==================================================
+ Hits                    7675     7676    +1     
  Misses                  1832     1832           
  Partials                 588      588           

Files	Coverage Δ
.../network/http/CountingInputStreamWithCallback.java	43.58% <100.00%> (ø)
...nal/network/http/EmbraceUrlConnectionDelegate.java	82.79% <100.00%> (+0.06%)	⬆️

[fractalwrench]

LGTM