Only cache payloads matching the current session

[bidetofevil]

Goal

Only do the session caching if the sessionId of the session object to be cached matches the current session

Testing

Added tests where the caching runs after the current session has moved on to ensure no saving is done.

[bidetofevil]

• Only cache payloads matching the current session #855 👈
• Refactor the SessionOrchestrator tests to use a real PayloadFactory #854
• Improve FakeDeliveryService to better differentiate sessions and background activities #846
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[fractalwrench]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 80.76%. Comparing base (fb2dad9) to head (bd36671).
Report is 1 commits behind head on master.

❗ Current head bd36671 differs from pull request most recent head 9b8e510

Please upload reports for the commit 9b8e510 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   80.80%   80.76%   -0.04%     
==========================================
  Files         429      429              
  Lines       11465    11469       +4     
  Branches     1750     1752       +2     
==========================================
- Hits         9264     9263       -1     
- Misses       1445     1446       +1     
- Partials      756      760       +4     

Files	Coverage Δ
...dk/session/orchestrator/SessionOrchestratorImpl.kt	91.60% <66.66%> (-1.20%)	⬇️

... and 2 files with indirect coverage changes

[bidetofevil]

Merge activity

• May 17, 1:24 PM EDT: @bidetofevil merged this pull request with Graphite.