Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split EmbraceImpl implementation into API delegates #849

Merged
merged 1 commit into from
May 17, 2024

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented May 16, 2024

Goal

Splits the EmbraceImpl implementation so the user API is implemented as a delegate. Future changesets will factor other related APIs into appropriate delegates.

Testing

Added unit test coverage.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 80.78%. Comparing base (0131c8e) to head (6a0dfaf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
- Coverage   80.89%   80.78%   -0.12%     
==========================================
  Files         424      426       +2     
  Lines       11458    11464       +6     
  Branches     1748     1748              
==========================================
- Hits         9269     9261       -8     
- Misses       1433     1448      +15     
+ Partials      756      755       -1     
Files Coverage Δ
.../android/embracesdk/injection/InjectEmbraceImpl.kt 100.00% <100.00%> (ø)
...embracesdk/internal/api/delegate/SdkCallChecker.kt 85.71% <85.71%> (ø)
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt 61.23% <21.42%> (+6.16%) ⬆️
...mbracesdk/internal/api/delegate/UserApiDelegate.kt 8.33% <8.33%> (ø)

... and 3 files with indirect coverage changes

@fractalwrench fractalwrench marked this pull request as draft May 16, 2024 10:56
@fractalwrench fractalwrench marked this pull request as ready for review May 16, 2024 12:44
@fractalwrench fractalwrench force-pushed the emb-impl-refactor branch 2 times, most recently from 013e695 to 82df9ef Compare May 16, 2024 13:41
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Keep them coming!

Base automatically changed from poc-embrace-impl-prop to master May 17, 2024 08:48
@fractalwrench fractalwrench merged commit ea0eca8 into master May 17, 2024
3 of 4 checks passed
@fractalwrench fractalwrench deleted the emb-impl-refactor branch May 17, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants