Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and convert nanosecond timestamps for all timestamp parameters #845

Merged
merged 1 commit into from
May 15, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented May 14, 2024

Goal

Use nanosecond fallback for all timestamp parameters. This is because the hosted SDKs are passing in nanosecond time because that's what iOS expects, so we'll just support it on every parameter, rather than just the ones that had previously been in nanoseconds so customers might be using it.

Testing

Added tests in every layer

@bidetofevil bidetofevil requested a review from a team as a code owner May 14, 2024 20:55
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (82666fd) to head (e81184c).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
+ Coverage   81.09%   81.38%   +0.29%     
==========================================
  Files         424      423       -1     
  Lines       11465    11419      -46     
  Branches     1704     1698       -6     
==========================================
- Hits         9297     9293       -4     
+ Misses       1453     1419      -34     
+ Partials      715      707       -8     
Files Coverage Δ
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 86.36% <100.00%> (ø)
...android/embracesdk/internal/spans/EmbraceTracer.kt 96.55% <100.00%> (ø)
...ndroid/embracesdk/internal/spans/InternalTracer.kt 93.65% <100.00%> (+0.31%) ⬆️

... and 25 files with indirect coverage changes

@bidetofevil bidetofevil requested a review from TheMutsi May 14, 2024 21:28
@bidetofevil bidetofevil merged commit 30194c1 into master May 15, 2024
4 checks passed
@bidetofevil bidetofevil deleted the hho/span-fallback-times branch May 15, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants