Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app state from internal errors #842

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes app state from internal errors as it's unused. This allowed moving the InternalErrorService a bit earlier in the initialization order so we can capture errors as soon as possible.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner May 13, 2024 14:12
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@f87a761). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #842   +/-   ##
=========================================
  Coverage          ?   81.27%           
=========================================
  Files             ?      423           
  Lines             ?    11413           
  Branches          ?     1695           
=========================================
  Hits              ?     9276           
  Misses            ?     1428           
  Partials          ?      709           
Files Coverage Δ
...ava/io/embrace/android/embracesdk/EmbraceImpl.java 66.23% <100.00%> (ø)
...embrace/android/embracesdk/injection/InitModule.kt 100.00% <100.00%> (ø)
...oid/embracesdk/injection/ModuleInitBootstrapper.kt 90.84% <100.00%> (ø)
...race/android/embracesdk/injection/PayloadModule.kt 100.00% <100.00%> (ø)
...race/android/embracesdk/injection/SessionModule.kt 100.00% <100.00%> (ø)
.../embracesdk/internal/payload/ExceptionErrorInfo.kt 100.00% <ø> (ø)
.../embracesdk/logging/EmbraceInternalErrorService.kt 90.90% <ø> (ø)
...android/embracesdk/payload/LegacyExceptionError.kt 94.11% <ø> (ø)
...oid/embracesdk/payload/LegacyExceptionErrorInfo.kt 83.33% <66.66%> (ø)

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the internal-err-service-refactor branch from a1870a7 to 963c0fe Compare May 14, 2024 09:31
Base automatically changed from internal-err-service-refactor to master May 14, 2024 09:49
@fractalwrench fractalwrench merged commit 04ad926 into master May 14, 2024
4 checks passed
@fractalwrench fractalwrench deleted the remove-app-state branch May 14, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants