Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lifecycle owner dependency #841

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Updates the androidx lifecycle dependency to the latest version.

Testing

I checked the release notes and it seems to be only bug fixes + Kotlin conversions which shouldn't affect our use-case. I tested in our example app to confirm a session was reported to the dashboard.

@fractalwrench fractalwrench requested a review from a team as a code owner May 13, 2024 13:00
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.25%. Comparing base (04ad926) to head (ca009cd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   81.28%   81.25%   -0.04%     
==========================================
  Files         423      423              
  Lines       11413    11416       +3     
  Branches     1695     1696       +1     
==========================================
- Hits         9277     9276       -1     
- Misses       1428     1429       +1     
- Partials      708      711       +3     
Files Coverage Δ
...dk/session/lifecycle/EmbraceProcessStateService.kt 82.60% <50.00%> (-5.77%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@fractalwrench fractalwrench merged commit 76ab112 into master May 14, 2024
4 checks passed
@fractalwrench fractalwrench deleted the update-lifecycle-owner branch May 14, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants