Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert internal error service to implement data capture service #840

Merged
merged 1 commit into from
May 14, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Converts the internal error service to implement the data capture service interface. This standardises how data is cleared between sessions & reduces the complexity of the previous implementation.

I have also removed logic for ignoring throwables as part of this changeset. Originally we searched the Throwable chain to see if any exceptions were network-connectivity errors, and skipped sending them if so. As we manually curate the exceptions we deliver to the backend now, this is not necessary anymore.

Testing

Updated existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner May 13, 2024 10:39
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (82666fd) to head (963c0fe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
- Coverage   81.09%   81.06%   -0.03%     
==========================================
  Files         424      424              
  Lines       11465    11437      -28     
  Branches     1704     1697       -7     
==========================================
- Hits         9297     9271      -26     
- Misses       1453     1454       +1     
+ Partials      715      712       -3     
Files Coverage Δ
...pture/envelope/session/SessionPayloadSourceImpl.kt 100.00% <100.00%> (ø)
...race/android/embracesdk/injection/SessionModule.kt 100.00% <ø> (ø)
.../embracesdk/logging/EmbraceInternalErrorService.kt 93.75% <100.00%> (+8.03%) ⬆️
.../embracesdk/session/EmbraceMemoryCleanerService.kt 100.00% <ø> (ø)
...acesdk/session/message/V1PayloadMessageCollator.kt 96.80% <100.00%> (ø)
...ssion/orchestrator/OrchestratorBoundaryDelegate.kt 75.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the internal-err-service-refactor branch from a1870a7 to 963c0fe Compare May 14, 2024 09:31
@fractalwrench fractalwrench merged commit f87a761 into master May 14, 2024
4 checks passed
@fractalwrench fractalwrench deleted the internal-err-service-refactor branch May 14, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants